Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker ecr login plugin as tools #792

Merged
merged 3 commits into from
May 28, 2024
Merged

Add docker ecr login plugin as tools #792

merged 3 commits into from
May 28, 2024

Conversation

pat-trunk-io
Copy link
Contributor

@pat-trunk-io pat-trunk-io commented May 28, 2024

Docker doesn't install this by default anymore. Adding it for easy install for new hires.

Copy link

trunk-io bot commented May 28, 2024

⏱️ 17m total CI duration on this PR
Job Cumulative Duration Recent Runs
Windows Tool Tests 5m 🟥🟩
CodeQL-Build 3m 🟩🟩🟩
Tool Tests (ubuntu-latest) 3m 🟩🟥🟩
Trunk Check runner [linux] 2m 🟩🟥🟩
Tool Tests (macOS) 2m 🟩🟥🟩
Repo Tests / Plugin Tests 1m 🟩🟥🟩
Detect changed files 16s 🟩🟩🟩
Aggregate Test Results 11s 🟩🟥🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

@pat-trunk-io pat-trunk-io requested review from TylerJang27 and det May 28, 2024 21:43
tools/docker-credential-ecr-login/plugin.yaml Outdated Show resolved Hide resolved
@pat-trunk-io pat-trunk-io enabled auto-merge (squash) May 28, 2024 21:47
@pat-trunk-io pat-trunk-io merged commit 3d53c55 into main May 28, 2024
14 checks passed
@pat-trunk-io pat-trunk-io deleted the pat/EcrLogin branch May 28, 2024 21:54
Copy link

trunk-staging-io bot commented May 28, 2024

💊 0 quarantined ✅ 1 passed 🕐 1 new ⋅ (learn more)

docs ⋅ learn more about trunk.io

Copy link

💊 0 quarantined ✅ 0 passed 🕐 2 new ⋅ (learn more)

❌ 2 failed tests status
Testing tool docker-credential-ecr-login Linux main > Testing tool docker-credential-ecr-login docker-credential-ecr-login -v
Testing tool docker-credential-ecr-login Linux main > Test execution failure: could be caused by test hooks like 'afterAll'.

docs ⋅ learn more about trunk.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants